Adjusted for working with URL rewrite#3
Open
mpetrunic wants to merge 2 commits intolatrell:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using full file name as request param (like user.json) it does't work with URL rewriting. Of course you could write URL-s with index.php but that isn't so pretty and usually is confusing. Also I don't quite get purpose of suffix option in configuration. You hard coded resource files in .json so suffix only modifies request param name and causes error 404. It is best to leave suffix blank and remove it from conf file. I might be using this wrong but would like to hear your response.