-
Notifications
You must be signed in to change notification settings - Fork 10
fix(RO-2202): code line height aligned with figma #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0830f83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Size Change: +1 B (0%) Total Size: 533 kB
ℹ️ View Unchanged
|
|
|
||
| .small { | ||
| font-size: var(--lp-font-size-100); | ||
| line-height: var(--lp-line-height-100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we can't use the font tokens, like lp-text-code-1-regular and co.?
Summary
Previously
Codecomponent line height was varying depending on the context where it was used but now line height is explicitly set based on Figma line-height to avoid unexpected vertical stretching/squeezing.Related Jira issue: RO-2202: [Nice to have] Align LP Code component line-height with Figma