Open
Conversation
Owner
|
AFAIK, the edit command is already implemented in lftp. Memory management can be improved using x* containers (xstring etc). Please consider configure --without-modules too. |
Owner
|
cmd_edit has clearly a memory leak. |
peti
force-pushed
the
master
branch
4 times, most recently
from
4555d5d to
fa07923
Compare
If the instance isn't deinitialized prior to exit, the OPENSSL_cleanup exit handler may run before the lftp_ssl_openssl_instance destructor on exit resulting in a segfault. This fixes a null deref on exit. Fixes lavv17#716
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi we at openSUSE had a crazy patchset that allows creating ftp wrapper using lftp.
I would like to merge this upstream, atm that is not really possible like one fo the files is C instead of C++ and so on. But before we start to really review this it would be nice to get info if we are doing something really bad based on current codebase (the actual patches are from around 2005...)