WIP Chainquery mysqlsocket #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopere
added
type: improvement
EnigmaCurry
requested changes
Apr 29, 2019
Collaborator
EnigmaCurry
left a comment
EnigmaCurry
left a comment
There was a problem hiding this comment.
I think start.sh needs to be configurable as to whether to run in socket mode or TCP mode. So another environment variable? MYSQL_USE_SOCKET=true ?
TCP is the only way that will work in a multi-host environment where mysql and chainquery live on seperate hosts.
Collaborator
Author
|
Migrating to Percona #69 will stop this from being useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an update for chainqueries container to add a direct mysql.socket connection instead of using TCP connectivity on the localhost. This improves reliability, security, and speed.