-
-
Notifications
You must be signed in to change notification settings - Fork 192
feat(extension): improve server connection handling and add sponsor #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add graceful handling when Huntly server connection fails, showing warning and allowing AI features to work with external providers - Hide Huntly AI option in toolbar when server is not connected - Fix shortcuts_preview message being sent twice by adding skipPreview flag when preview is already open - Bump extension version to 0.5.2 - Add jtsang4 to sponsors list Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Augment PR SummarySummary: Improves the extension’s resilience when the Huntly server can’t be reached, while keeping AI features usable via external providers. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {/* Server configured but not signed in and server is reachable */} | ||
| { | ||
| !loadingUser && storageSettings?.serverUrl && !username && <div> | ||
| !loadingUser && storageSettings?.serverUrl && !username && !serverConnectionFailed && <div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When serverConnectionFailed is true, the sign-in CTA is hidden entirely; if the outage is transient, the user can’t retry sign-in without closing/reopening the popup. Consider whether a retry/sign-in path should still be available in this state.
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| {/* Server configured and signed in, no server configured (read-only mode), or server connection failed */} | ||
| { | ||
| !loadingUser && (username || !storageSettings?.serverUrl) && <div> | ||
| !loadingUser && (username || !storageSettings?.serverUrl || serverConnectionFailed) && <div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including serverConnectionFailed in this branch means the RSS subscription UI will still render and call server APIs (previewFeed/subscribeFeed), which will likely error and may confuse users. It might be worth gating RSS subscription similarly or surfacing a clearer “server required” message.
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| onShortcutClick={handleAIShortcutClick} | ||
| isProcessing={processingShortcut} | ||
| compact={true} | ||
| hideHuntlyAI={serverConnectionFailed} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of hideHuntlyAI here, but the preview window (ArticlePreview) also renders AIToolbar and may still show huntly-server models even when the popup detected a connection failure. If the intent is to hide Huntly AI whenever the server isn’t reachable, you may need to propagate that state into the preview as well.
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Summary
Test plan
🤖 Generated with Claude Code