feat: adding free reader monad API and minor edits to free writer and free cont #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerduve
force-pushed
the
tannerduve/free-monad-edits
branch
from
59483c2 to
235d946
Compare
Collaborator
|
@eric-wieser @quangvdao I recall you having thoughts on the initial PR, anything for this one? |
|
none, looks good to me. glad this is now in cslib! |
chenson2018
approved these changes
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
eric-wieser
reviewed
Jan 12, 2026
Contributor
Author
|
@eric-wieser i added Since this PR is meant to be about adding the reader monad to the free effects library, I think I'll just remove the censor stuff for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API for the
Readermonad represented as a free monad, to the list of existing free effects. Also made some minor changes to theWriterandContAPIs in this same file