everything but the bonus #21
Conversation
krepysh
left a comment
krepysh
left a comment
There was a problem hiding this comment.
Повторяющиеся проблемы (is not None, _ как имя переменной) не в каждом месте отмечал, исправь везде пожалуйста.
for_challenges.py
Outdated
| 'Маша': False, | ||
| } | ||
| for name in is_male: | ||
| if is_male[name] == True: |
There was a problem hiding this comment.
Лучше не сравнивать с True, просто if is_male[name]:
for_challenges.py
Outdated
| ['Вася', 'Маша', 'Саша', 'Женя'], | ||
| ['Оля', 'Петя', 'Гриша'], | ||
| ] | ||
| print(f'Всего груп: {len(groups)}') |
for_dict_challenges.py
Outdated
| for student in students: | ||
| name = student['first_name'] | ||
| if names.get(name) == None: | ||
| names[name] = 1 |
There was a problem hiding this comment.
Тут можно без if обойтись
| names[name] = 1 | |
| names[name] = names.get(name, 0) + 1 |
for_dict_challenges.py
Outdated
| for student in students: | ||
| name = student['first_name'] | ||
| if names.get(name) == None: | ||
| names[name] = 1 |
There was a problem hiding this comment.
Здесь можно использовать решение предыдущей задачи, если обернуть его в функцию.
for_dict_challenges.py
Outdated
| for grade in school_students: | ||
| names = {} | ||
| for student in grade: | ||
| name = student['first_name'] |
There was a problem hiding this comment.
Аналогично, можно использовать решение первой задачи тут.
for_dict_challenges_bonus.py
Outdated
| number_responses_per_user = {} | ||
| for _ in chat_history: | ||
| message_id = _['id'] | ||
| for i in number_answers: |
for_dict_challenges_bonus.py
Outdated
| else: | ||
| number_responses_per_user[_['sent_by']] += number_answers[i] | ||
| most_cited = max(number_responses_per_user.values()) | ||
| for _ in number_responses_per_user: |
for_dict_challenges_bonus.py
Outdated
| message_id = _['id'] | ||
| for i in number_answers: | ||
| if i == message_id: | ||
| if number_responses_per_user.get(_['sent_by']) == None: |
There was a problem hiding this comment.
Если избавимся от if так же как раньше, код значительно упростится.
for_dict_challenges_bonus.py
Outdated
| who_saw = [] | ||
| message_list = user_messages[_] | ||
| for i in message_list: | ||
| for j in chat_history: |
There was a problem hiding this comment.
что такое i, j? переименуй на что-то более понятное плиз
for_dict_challenges_bonus.py
Outdated
| by = _['id'] | ||
| beginning = _['reply_for'] | ||
| if answer == False: | ||
| while beginning != None and beginning != []: |
There was a problem hiding this comment.
is not None
любой не пустой словарь будет true, можно сделать
| while beginning != None and beginning != []: | |
| while beginning is not None and beginning: |
… решения задач в функции для дальнейшего использования
2 participants
No description provided.