Open
Conversation
sanglt1902
requested review from
boomspeed94,
cymonkey,
danielvo11 and
quocle108
Codecov Report
@@ Coverage Diff @@
## develop #125 +/- ##
========================================
Coverage 95.16% 95.16%
========================================
Files 69 69
Lines 1096 1096
Branches 129 129
========================================
Hits 1043 1043
Misses 53 53 Continue to review full report at Codecov.
|
danielvo11
requested changes
Dec 2, 2020
Contributor
danielvo11
left a comment
danielvo11
left a comment
There was a problem hiding this comment.
I think this command should be added to https://github.com/lecle/aloxide/blob/master/packages/abstraction/bin/aloxide.js
|
|
||
| // Handle file type | ||
| if (FILE_TYPE.JSON == fileType) { | ||
| writeJSONFile(`${fullPath}.${fileType.toLowerCase()}`, aloxideEntities); |
Contributor
There was a problem hiding this comment.
Should write json file as pretty format!
| const ENTITY_NAME_QUESTION = "What's your entity name?\n"; | ||
| const PROP_NAME_QUESTION = "What's your property name?\n"; | ||
| const PROP_TYPE_QUESTION = "What's your property type?\n"; | ||
| const CONFIRM_PROP_QUESTION = "Do you want to continue create new Entity's property?\n"; |
Contributor
There was a problem hiding this comment.
question ask for y/n, but when I type anythings else, it still process as case n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR to create a new js file to help generate entity file
To test please follow these steps.
And then answers the questions that will be appeared on your screen to generate your entities