Upgrade arrow_path to version 3.1.0#34
Merged
lempiy merged 1 commit intolempiy:masterfrom Mar 28, 2025
Merged
Conversation
ArrowPath.make() is now deprecated, use ArrowPath.addTip() instead.
Owner
|
Hi, ty. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this PR finds you well and safe.
Migration to 3.1.0
ArrowPath.make() is now deprecated, we need to use ArrowPath.addTip() instead.
If we are not using the
isDoubleSidedargument of ArrowPath.make() then we can safely replace it by ArrowPath.addTip() without any other change.But we are using the
isDoubleSidedargument of ArrowPath.make() then we need to change the code like this:Before:
After:
Thank you for reviewing this contribution when you have the opportunity.