fix: handle version suffix like 'p1', 'a', 'b' in compare()#7
Open
contem wants to merge 1 commit intoleohihimax:masterfrom
Open
fix: handle version suffix like 'p1', 'a', 'b' in compare()#7contem wants to merge 1 commit intoleohihimax:masterfrom
contem wants to merge 1 commit intoleohihimax:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
compare()function to correctly handle version strings that include suffixes such as8.5p1,10.2a, etc. These suffixes are commonly used in systems like OpenSSH.Before:
compare('8.5', '8.5p1'); // returned 0 (incorrect)
After:
compare('8.5', '8.5p1'); // now returns -1 (correct)
Changes:
split()to detect and separate numeric-alphabetic suffixes.convertToNumber()to preserve alphas properly.test.js(optional).Let me know if any changes are needed!