Make multiple shortcodes possible#10
Open
simonvomeyser wants to merge 1 commit intolesterchan:masterfrom
Open
Conversation
Append the number of current shortcode to the id to make them unique. Avoids dublicate ids in DOM Closes lesterchan#9
Author
|
Hey, did you have time to look into that? And failing check seems to come from travis itself in combination with php 5.3 and is not caused by my code :)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append the number of current shortcode to the id to make them unique.
Avoids dublicate ids in DOM
Closes #9