Skip to content

Comments

Added AlphaVantage adapter#55

Open
jdambacher wants to merge 4 commits intolexik:masterfrom
coffee-bike:master
Open

Added AlphaVantage adapter#55
jdambacher wants to merge 4 commits intolexik:masterfrom
coffee-bike:master

Conversation

@jdambacher
Copy link
Contributor

In fact of Yahoo's decision to discontinue the Yahoo Finance API, I decided to search for another exchange rate service and found the free AlphaVantage API. You only have to obtain a free API key at https://www.alphavantage.co/support/#api-key

Fixes lexik#54 - lexik:currency:import yahoo not working
@jdambacher
Copy link
Contributor Author

@cedric-g Do you need any information in order to merge this PR?

@jdambacher
Copy link
Contributor Author

Would be very nice, if you can merge this. Adapter is completely tested and working.

@jdambacher
Copy link
Contributor Author

@lexikteam Any update on this?

@gilles-g
Copy link
Member

@jdambacher
Hi,

Sorry for the delay it's difficult this time for us to maintain all theses bundles 😄

I wanted to merge your PR, but I'm not sure about if we have to delete the yahoo adapter in the same PR. This could add some BC for users who still use YahooAdapter.

Maybe you could remove your last commit for this PR, and create an other PR for Yahoo, and I'll create a special tag for this deletion. What do you think?

@gilles-g gilles-g self-assigned this Jul 23, 2018
@jdambacher
Copy link
Contributor Author

@Spike31 No worries!

I think this is the only option, because the yahoo API is completely disabled. I agree this i a BC, but the adapter is currently completely useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants