gic max version to boot on newer arm64 hosts #886
Conversation
I can see problems while running on arm64 hosts with acceleration. Seems we should align gic version with the host one. According to docs (https://www.qemu.org/docs/master/system/arm/virt .html?highlight=gic%20version), max is the best option here. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
uncleDecart
left a comment
uncleDecart
left a comment
There was a problem hiding this comment.
LGTM, but I'd wait for BuildJet to merge or test in on buildjet runners, because they provide arm runners
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
LGTM but do we want to wait until we've had some run(s) with the buildjet runners?
As I understand, we want to check arm buildjet runners and potentially stabilise other issues as well. |
|
Exactly @giggsoff , right now we are running manually buildjet workflow ot see if there any problems If not, we should explore buildjet arm runners (since they provide them) and if there is no problem with that, we can run this PR on buildjet arm runner and if it's successful, we can merge it |
3 participants
I can see problems while running on arm64 hosts with acceleration. Seems we should align gic version with the host one. According to docs,
maxis the best option here.