Properly cd after wt setup is ran

[liamawhite]

fixes a bug

[claude]

Claude finished @liamawhite's task —— View job

---

PR Review

I've analyzed this pull request and the bug fix looks good overall. Here's my comprehensive review:

Todo List:

• Read repository guidelines (CLAUDE.md)
• Analyze changed files to understand the bug fix
• Review .goreleaser.yml changes
• Review integration test changes
• Review worktree.sh script changes
• Provide comprehensive feedback

Understanding the Bug Fix

This PR addresses a bug where the worktree setup command wasn't triggering automatic directory changes in the shell wrapper function. The fix consistently adds "setup" to the command list across three files.

Code Quality Review

✅ Positive Aspects:

1. Consistency: The fix is applied consistently across all relevant files:

   • worktree.sh:24 - Updated the shell function condition
   • .goreleaser.yml:125 - Updated the embedded documentation
   • integration/integration_test.go - Simplified test expectations

2. Logic Correctness: The conditional logic || "$cmd" == "setup" correctly extends the existing pattern without breaking other functionality.

3. Clean Test Simplification: The integration test changes in integration_test.go:51-58 remove unnecessary directory change logic, which aligns with the fix since setup should now handle directory changes automatically.

4. Documentation Accuracy: The release documentation is updated to reflect the new behavior, mentioning all three commands: add, switch, and setup.

⚠️ Minor Concerns:

1. Test Coverage Gap: The integration test no longer explicitly verifies that the setup command actually changes directories. Consider adding a test case that verifies:

   // Verify setup command changes to correct directory
   initialDir, _ := os.Getwd()
   // Run setup command
   // Verify current directory changed to expected location

2. Shell Function Robustness: The shell function in worktree.sh:24 could benefit from input validation:

   # Consider adding basic validation
   if [[ -z "$cmd" ]]; then
       echo "Error: No command specified"
       return 1
   fi

Security Analysis

✅ No security concerns identified:

• No external input validation issues
• File operations use safe patterns with proper cleanup
• No credential or sensitive data handling changes

Performance Considerations

✅ No performance impact:

• Changes are simple string comparisons in conditional logic
• No additional system calls or resource usage
• Test simplification actually reduces overhead

Best Practices Assessment

✅ Follows repository conventions:

• Maintains existing code style and patterns
• Uses proper Go testing conventions with testify
• Shell script follows bash best practices with proper quoting and error handling

Recommendations

1. Add explicit test coverage for the setup directory change behavior to prevent regression
2. Consider documenting the WT_CHDIR protocol in the main README or in code comments for future maintainers

Summary

This is a solid bug fix that addresses the missing setup command in the shell wrapper's directory-changing logic. The implementation is consistent, well-executed, and follows the existing patterns. The only suggestion is to add explicit test coverage for the new behavior to ensure it works as expected and prevent future regressions.

Recommendation: ✅ Approve - This PR successfully fixes the reported bug with minimal, targeted changes.

---