BLD: prefer to use bdist_wheel from setuptools rather than wheel#162
Merged
avalentino merged 1 commit intoliberfa:mainfrom Oct 24, 2024
Merged
Conversation
Contributor
|
I think it's fine to use a try/except here but we should probably have a comment stating which version of setuptools first supported this. |
Due to upcoming changes to setuptools (pypa/setuptools#4647) using bdist_wheel from wheel will fail.
tacaswell
force-pushed
the
bld/prefer_setuptools_wheel
branch
from
b284a16 to
d5c7bfe
Compare
Contributor
Author
|
Added a comment with when it is available in setuptools (70.1) |
neutrinoceros
approved these changes
Oct 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to upcoming changes to
setuptools (pypa/setuptools#4647) using bdist_wheel from wheel will fail.
I suspect that this could be simplified by setting a high enough floor on setuptools and dropping wheel as build dependencies, but I am not sure how the window of support of bdist_wheel in setuptools maps to your window of versions of setuptools you want to support.