Makefile.miyoo: use generic call for SYSROOT path#18747
Merged
LibretroAdmin merged 1 commit intolibretro:masterfrom Feb 19, 2026
Merged
Makefile.miyoo: use generic call for SYSROOT path#18747LibretroAdmin merged 1 commit intolibretro:masterfrom
LibretroAdmin merged 1 commit intolibretro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Allows easy building with other libC implementations (e.g musl), not necessary uclibc.
Off-Topic (question)
We're slowly switching to musl based system on Miyoo arm32, mostly for performance reasons (might be less stable), but allowing for uClibc in separate CFW image with better backward compatibility (our old toolchain, the one in libretro buildbot is using uclibc).
Question: For future and for ppl to be using
muslbased OS, would it be possible to add another template in libretro infrastucture? Probably dup of dingux-arm32.yml with imagelibretro-build-dingux:muslby adding Dockerfile.musl (mirror of Dockerfile with latest musl dynamic toolchain) and another SDK. Writing it down, cuz I'm not sure if anybody "outside" is allowed to make any PR in self-hosted gitlab.