Add a helper function to set thread name in rthread#167
Merged
inactive123 merged 2 commits intolibretro:masterfrom Sep 1, 2020
Merged
Add a helper function to set thread name in rthread#167inactive123 merged 2 commits intolibretro:masterfrom
inactive123 merged 2 commits intolibretro:masterfrom
Conversation
Contributor
|
I have to unfortunately revert this for now, this breaks Apple - http://paste.libretro.com/199461 If you can find a way to fix this for all platforms, I will happily merge whatever new PR you have. But breaking platforms like this is not an option. |
Contributor
Author
|
Do you have an Apple CI I could use? I don’t have any such computer. Edit: apparently their libc doesn’t support setting the name of a thread other than the currently-running one?! See https://opensource.apple.com/source/Libc/Libc-825.25/pthreads/pthread.c.auto.html |
Contributor
Author
|
This is now superseded by #169. You should at least have kept the documentation fix. ^^' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from TASEmulators/desmume#367
I don’t have any Windows to test things on, so I only implemented it for pthread for now.