Libretro: add USE_LOW_GBA_RESAMPLE_RATE flag to force GBA resample rate to 32768 (65536/2) in low-end platforms#312
Open
saulfabregwiivc wants to merge 2 commits intolibretro:masterfrom
Conversation
Collaborator
|
I implemented something similar in c758314 that I think will hopefully be a little more flexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from this commit 0f39405, some low-end platforms (such NGC, Wii, Wii U) have performance issues because of the too high GBA resample rate value (65536), since more sampling requires more processing power requirements.
Here i added a new flag in Makefile.libretro called USE_LOW_GBA_RESAMPLE_RATE, which if passed it will use the old GBA resample rate (32768, which is basically 65536/2), which benefits low-end platforms and gives them a speed tweak.