reimplement multi gba patch#81
reimplement multi gba patch#81andres-asm wants to merge 1 commit intolibretro:splitscreenfrom andres-asm:master
Conversation
| core1->reset(core1); | ||
| _setupMaps(core1); | ||
| core2->reset(core2); | ||
| _setupMaps(core2); |
There was a problem hiding this comment.
I'm about 80% sure calling this function four times will leak memory or otherwise misbehave. You're hardcoding core1 anyways, remove the other three calls. The resets are fine.
There was a problem hiding this comment.
You mean the setupMaps stuff?
I just did everything 4x but I wasn't sure of that yeah
| _setupMaps(core); | ||
|
|
||
| core1->reset(core1); | ||
| _setupMaps(core1); |
There was a problem hiding this comment.
wait, why is this called from two different places, is that really correct
There was a problem hiding this comment.
isn't this retro_load_game? I'm just following the original core here
| core1->saveState(core1, tmp); | ||
| memcpy(data, tmp, tmp_size); | ||
| free(tmp); | ||
| tmp = malloc(tmp_size); |
There was a problem hiding this comment.
can't say freeing and immediately allocating a new one makes much sense, but I guess it does no harm either?
There was a problem hiding this comment.
ah yeah considering it's the same size you're right
I think in core1->deinit(core1); if may free the memory allocated to the game already so that may be why it crashes? |
|
Link API is probably gonna be rewritten soonish so it may make sense to lay off the link implementation for a bit. |
|
Thanks for the heads-up I just wanted to get the "multi-core core" working first I have no idea on how to implement the API anyhow :) |
3 participants
No description provided.