Refactors by LibretroAdmin · Pull Request #121 · libretro/tyrquake

LibretroAdmin · 2022-06-10T18:48:58Z

No description provided.

… libretro port: - cl_shownet - developer - entities - mcache - host_framerate - host_speeds - maplist - d_subdiv16 - hunk * Get rid of PARANOID ifdefs - never used and speed-sapping according to own internal comments * Keys - get rid of console autocompletion - will never be used * Get rid of useless window_visible - libretro port doesn't need to have a concept of this * Get rid of useless onscreen logging functionality like R_TimeRefresh, R_TimeGraph, R_ZGraph, etc. * Get rid of Con_DPrintf - only ever used when developer switch is set, which will never be the case for the libretro port * Get rid of debuglog

of alternate r_pixbytes codepaths - less conditionals, less code

never change from this, remove all alternate code paths

* Remove some unused variables/command variables * Simplify audio code - shm->samples will always be constant, so use a constant define. Plan to eventually get rid of shm struct/pointer (see comment in snd_dma/snd_mix.c code that this should be removed eventually)

…fcache_s) * Remove unneeded low floating point/high floating point mode setting (this was only ever relevant on old 486/Pentium era CPUs) * Get rid of more useless debug functions * Direct initialization of local variables where possible

…el_prev, viewmodel_next, version

* draworder always 0, remove conditional * Random miscellaneous cleanups, make functions static if we can

from now on to core options

* Get rid of r_vars.c

lgtm-com · 2022-06-10T18:53:56Z

This pull request fixes 42 alerts when merging 67bd259 into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T19:06:35Z

This pull request fixes 42 alerts when merging c7d6d6d into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T19:12:37Z

This pull request fixes 42 alerts when merging 8a3b554 into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T19:30:41Z

This pull request fixes 42 alerts when merging 8d94cd3 into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T20:07:50Z

This pull request fixes 42 alerts when merging cfe5014 into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T20:14:43Z

This pull request fixes 42 alerts when merging a8ea1e1 into c2b8ea0 - view on LGTM.com

fixed alerts:

23 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-11T20:56:37Z

This pull request fixes 43 alerts when merging a273599 into c2b8ea0 - view on LGTM.com

fixed alerts:

24 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

* Use strlcpy where possible instead of snprintf * Get rid of 'bad CDRIP'warning whenever an audio track cannot be found

lgtm-com · 2022-06-12T14:23:22Z

This pull request fixes 43 alerts when merging e04da40 into c2b8ea0 - view on LGTM.com

fixed alerts:

24 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-12T16:41:34Z

This pull request fixes 43 alerts when merging 9911d91 into c2b8ea0 - view on LGTM.com

fixed alerts:

24 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-13T14:07:12Z

This pull request introduces 1 alert and fixes 44 when merging 2169d02 into c2b8ea0 - view on LGTM.com

new alerts:

1 for FIXME comment

fixed alerts:

25 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-06-13T19:56:23Z

This pull request introduces 1 alert and fixes 45 when merging 1947981 into c2b8ea0 - view on LGTM.com

new alerts:

1 for FIXME comment

fixed alerts:

26 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

lgtm-com · 2022-07-22T13:36:47Z

This pull request introduces 1 alert and fixes 45 when merging 1e2464b into e84d6c1 - view on LGTM.com

new alerts:

1 for FIXME comment

fixed alerts:

26 for FIXME comment
17 for Local variable hides global variable
1 for Wrong type of arguments to formatting function
1 for Too few arguments to formatting function

LibretroAdmin added 30 commits June 7, 2022 12:46

(snd_dma.c) Remove unnecessary console commands

5f05ce9

r_pixbytes is always going to be 1 for the libretro core, get rid

c1fbd4c

of alternate r_pixbytes codepaths - less conditionals, less code

Get rid of unused msg_suppress_

e0cc02b

Get rid of some unused variables as a result of earlier code refactors

fe821a7

Get rid of unused frontend VID_ functions in libretro.c

4f468cc

(Sound) Optimize around 16bit stereo sound, libretro port will

94bf7b8

never change from this, remove all alternate code paths

Remove if 0 codeblocks

431694a

No need for if 1 statements

d4f4167

Remove demo recording

e6023ef

Remove unused variables that got incremented every frame

6e408de

Remove scr_ram/scr_net and DrawNet

f62cf64

r_recursiveaffinetriangles is always enabled

bbc5d8e

Get rid of r_drawentities - remove more unused functions

3fc527c

Don't write keybinds to config.cfg

2d3450a

Remove unused function call declarations for rfprintf

67bb497

Cleanups

7fb147f

Miscellanous cleanups - turn functions static if we can

edc4517

Get rid of unnecessary console commands viewframe, viewmodel, viewmod…

63d299a

…el_prev, viewmodel_next, version

* COM_LoadPakFile - CRC checking on PAK file is unnecessary

a30501b

* draworder always 0, remove conditional * Random miscellaneous cleanups, make functions static if we can

Get rid of unused variables r_fullbright, r_ambient, r_pointfile

85b6e57

Get rid of unused snd_noextraupdate

4914587

Remove unused cl_warncmd

6ed9256

Remove unused extern

7750e1c

Cleanups

ededcc5

Cleanups in pr_exec.c

3ce2b42

Simplify code - get rid of unused net_win files

e98949c

Doesn't read or write to config.cfg anymore - options will be added

fb10716

from now on to core options

LibretroAdmin added 5 commits June 9, 2022 19:53

Cleanups

1f1c389

Remove unused R_LeadingEdgeBackwards

170a75e

* r_edge - don't go through function pointer

36c4b0d

* Get rid of r_vars.c

Remove D_CheckCacheGuard debug function

c439cc6

remove unused R_LineGraph

67bd259

LibretroAdmin added 3 commits June 11, 2022 20:53

Remove unused code - DebugLog

c7d6d6d

Remove unused variables

e168696

Remove pcx_t

8a3b554

Remove unused FPS_20 code and other miscellaneous unused things�

8d94cd3

LibretroAdmin added 2 commits June 11, 2022 21:55

Cleanups for pr_edict.c/cl_input.c

cfe5014

Remove unused Sys_Printf

a8ea1e1

Get rid of unused BOPS_Error

a273599

* Use fill_pathname_join where possible instead of snprintf

e04da40

* Use strlcpy where possible instead of snprintf * Get rid of 'bad CDRIP'warning whenever an audio track cannot be found

LibretroAdmin added 2 commits June 12, 2022 18:22

No return value for Sys_Error

10a70d6

Cleanups

9911d91

S_StopAllSounds - argument is always true

2169d02

General cleanups

1947981

Cut down on some strlens

1e2464b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactors#121

Refactors#121
LibretroAdmin wants to merge 48 commits intomasterfrom
refactors

LibretroAdmin commented Jun 10, 2022

Uh oh!

lgtm-com bot commented Jun 10, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 12, 2022

Uh oh!

lgtm-com bot commented Jun 12, 2022

Uh oh!

lgtm-com bot commented Jun 13, 2022

Uh oh!

lgtm-com bot commented Jun 13, 2022

Uh oh!

lgtm-com bot commented Jul 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

LibretroAdmin commented Jun 10, 2022

Uh oh!

lgtm-com bot commented Jun 10, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 11, 2022

Uh oh!

lgtm-com bot commented Jun 12, 2022

Uh oh!

lgtm-com bot commented Jun 12, 2022

Uh oh!

lgtm-com bot commented Jun 13, 2022

Uh oh!

lgtm-com bot commented Jun 13, 2022

Uh oh!

lgtm-com bot commented Jul 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant