feat: added wallet connect integration via api#357
Open
Conversation
…etConnect handling
…etConnect handling
…n void and enhance transaction validation
…n void and enhance transaction validation
jake4take
reviewed
Feb 10, 2026
| } | ||
|
|
||
| async setup() { | ||
| if (this.options.walletConfig.WALLET_TYPE === WalletConnectTypes.WC_SDK) { |
Contributor
There was a problem hiding this comment.
I think we can try not to add this condition here
jake4take
reviewed
Feb 10, 2026
| } | ||
|
|
||
| private setWalletPage() { | ||
| if (this.options.walletConfig.WALLET_TYPE === WalletConnectTypes.WC_SDK) { |
Contributor
There was a problem hiding this comment.
Can we move it to the switch..case condition below?
jake4take
reviewed
Feb 10, 2026
| } from './pages/elements'; | ||
| import { getAddress } from 'viem'; | ||
| import { isPopularMainnetNetwork, isPopularTestnetNetwork } from './helper'; | ||
| import { WCSessionRequest } from '../../walletConnect/wc.service'; |
Contributor
There was a problem hiding this comment.
Can you fill the index file and fix the import lines everywhere?
jake4take
reviewed
Feb 10, 2026
packages/wallets/src/okx/okx.page.ts
Outdated
|
|
||
| /** Confirm transaction */ | ||
| async confirmTx(page: Page) { | ||
| async confirmTx(page: Page | WCSessionRequest) { |
Contributor
There was a problem hiding this comment.
Can we use the same format here?
page: T extends WalletConnectTypes.WC_SDK ? WCSessionRequest : Page
…tion cancellation
…tion cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.