Add tx_signatures.tlvs field (splicing-specific field in dual funding message)#2991
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Apr 16, 2024
Merged
Conversation
0fd0ec6 to
dd5390a
Compare
dunxen
reviewed
Apr 15, 2024
Collaborator
|
LGTM, modulo @dunxen's comments. |
dd5390a to
bdbb177
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
==========================================
+ Coverage 89.40% 89.66% +0.25%
==========================================
Files 117 117
Lines 96016 98874 +2858
Branches 96016 98874 +2858
==========================================
+ Hits 85842 88653 +2811
- Misses 7957 8018 +61
+ Partials 2217 2203 -14 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Renamed field to more descriptive as suggested. |
dunxen
approved these changes
Apr 16, 2024
TheBlueMatt
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two relatively small changes, in preparation for splicing:
New
tx_signatures.tlvsfield. This field is splicing-specific, and is used for exchanging signature on the previous funding tx, which is a shared input. The spec of this is still non-finalized, just like for the rest of the already-added splicing messages (spec PRs Add funding outpoint sigs to tx_signatures message lightning/bolts#1009 Splice draft (feature 62/63) lightning/bolts#863)Place all Splicing messages -- which are still only placeholders without real functionality -- behind the recently-introduced
dual_fundingfeature flag. Splicing relies on dual funding, and is not usable without dual funding.Note: command for testing: