fix: test_payment_path_scoring failing#4395
fix: test_payment_path_scoring failing#4395okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 I see @joostjager was un-assigned. |
The fix ensures push_pending_event notifies the event_persist_notifier, which wakes the background processor's sleeper immediately instead of waiting for the 100ms poll timeout. It was the only event-producing path that didn't signal the notifier. Low risk since it's test-only code. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4395 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 156 156
Lines 103002 103036 +34
Branches 103002 103036 +34
=======================================
+ Hits 88620 88652 +32
- Misses 11873 11876 +3
+ Partials 2509 2508 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Root Cause
push_pending_event()pushes events to the pending queue without callingself.event_persist_notifier.notify(). The background processor'sSleepernever gets woken up for the new event, it only discovers it when the 100ms poll timeout expires. On slow or loaded CI machines, this can exceed the 5-secondEVENT_DEADLINE.Fix
Added
self.event_persist_notifier.notify()after pushing the event, consistent with how events are signaled throughout the rest of the codebase. This immediately wakes the background processor to handle the new event rather than relying on a poll timeout.Closes: #4085