-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update step-by-step send payment guide with docker #10461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -54,7 +54,7 @@ RPCUSER=$(set_default "$RPCUSER" "devuser") | |||||||||||||
| RPCPASS=$(set_default "$RPCPASS" "devpass") | ||||||||||||||
| DEBUG=$(set_default "$LND_DEBUG" "debug") | ||||||||||||||
| CHAIN=$(set_default "$CHAIN" "bitcoin") | ||||||||||||||
| HOSTNAME=$(hostname) | ||||||||||||||
| HOSTNAME=$(set_default "$HOSTNAME" "localhost") | ||||||||||||||
|
|
||||||||||||||
| # CAUTION: DO NOT use the --noseedback for production/mainnet setups, ever! | ||||||||||||||
| # Also, setting --rpclisten to $HOSTNAME will cause it to listen on an IP | ||||||||||||||
|
|
@@ -64,7 +64,6 @@ HOSTNAME=$(hostname) | |||||||||||||
| if [ "$BACKEND" == "bitcoind" ]; then | ||||||||||||||
| exec lnd \ | ||||||||||||||
| --noseedbackup \ | ||||||||||||||
| "--$CHAIN.active" \ | ||||||||||||||
| "--$CHAIN.$NETWORK" \ | ||||||||||||||
| "--$CHAIN.node"="$BACKEND" \ | ||||||||||||||
| "--$BACKEND.rpchost"="$RPCHOST" \ | ||||||||||||||
|
|
@@ -73,21 +72,18 @@ if [ "$BACKEND" == "bitcoind" ]; then | |||||||||||||
| "--$BACKEND.zmqpubrawblock"="tcp://$RPCHOST:28332" \ | ||||||||||||||
| "--$BACKEND.zmqpubrawtx"="tcp://$RPCHOST:28333" \ | ||||||||||||||
| "--rpclisten=$HOSTNAME:10009" \ | ||||||||||||||
| "--rpclisten=localhost:10009" \ | ||||||||||||||
| --debuglevel="$DEBUG" \ | ||||||||||||||
| "$@" | ||||||||||||||
| elif [ "$BACKEND" == "btcd" ]; then | ||||||||||||||
| exec lnd \ | ||||||||||||||
| --noseedbackup \ | ||||||||||||||
| "--$CHAIN.active" \ | ||||||||||||||
| "--$CHAIN.$NETWORK" \ | ||||||||||||||
|
Comment on lines
79
to
80
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||||||||||
| "--$CHAIN.node"="$BACKEND" \ | ||||||||||||||
| "--$BACKEND.rpccert"="$RPCCRTPATH" \ | ||||||||||||||
| "--$BACKEND.rpchost"="$RPCHOST" \ | ||||||||||||||
| "--$BACKEND.rpcuser"="$RPCUSER" \ | ||||||||||||||
| "--$BACKEND.rpcpass"="$RPCPASS" \ | ||||||||||||||
| "--rpclisten=$HOSTNAME:10009" \ | ||||||||||||||
| "--rpclisten=localhost:10009" \ | ||||||||||||||
|
Comment on lines
79
to
90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The removal of |
||||||||||||||
| --debuglevel="$DEBUG" \ | ||||||||||||||
| "$@" | ||||||||||||||
| else | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated introduction removes backticks from terms like
lnd,btcd, anddocker-compose.yml. For consistency with the rest of the document, where such terms are enclosed in backticks for code formatting, it would be better to add them.