Skip to content

scripts: update bw-compat test LND base version#10544

Merged
yyforyongyu merged 1 commit intolightningnetwork:masterfrom
ellemouton:updateBWCompatBaseVersion
Feb 3, 2026
Merged

scripts: update bw-compat test LND base version#10544
yyforyongyu merged 1 commit intolightningnetwork:masterfrom
ellemouton:updateBWCompatBaseVersion

Conversation

@ellemouton
Copy link
Collaborator

Update the backwards compat test to use lnd v0.20.0-beta as the base version.

Update the backwards compat test to use lnd v0.20.0-beta as the base
version.
@ellemouton ellemouton self-assigned this Feb 3, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @ellemouton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the base LND version used in the backward compatibility test suite. This ensures the test environment reflects a more current LND release, allowing for more relevant and up-to-date compatibility checks against the latest stable beta version.

Highlights

  • LND Version Update: The LND_LATEST_VERSION in the scripts/bw-compatibility-test/.env file has been updated from v0.18.5-beta to v0.20.0-beta.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • scripts/bw-compatibility-test/.env
    • Updated the LND_LATEST_VERSION variable from v0.18.5-beta to v0.20.0-beta.
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LND_LATEST_VERSION from v0.18.5-beta to v0.20.0-beta in the scripts/bw-compatibility-test/.env file. This change correctly configures the backwards compatibility test to use the newer LND version as its baseline, which aligns with the stated goal of the pull request. The change is straightforward and I found no issues to report.

@lightninglabs-deploy
Copy link
Collaborator

🟢 PR Severity: LOW

scripts configuration update | 1 file | 2 lines changed

🟢 Low (1 file)
  • scripts/bw-compatibility-test/.env - Test configuration file updating LND base version for backward compatibility tests

Analysis

This PR updates the base LND version used in backward compatibility testing from v0.18.5-beta to what appears to be a newer version. This change:

  • Only affects test infrastructure, not production code
  • Is confined to a single configuration file in the scripts/ directory
  • Has minimal lines changed (1 addition, 1 deletion)
  • Poses no risk to core LND functionality

According to the severity classification rules, changes to scripts/* files fall under LOW severity, requiring only best-effort review. This is a routine test configuration update that can be merged with minimal scrutiny.


To override, add a severity-override-{critical,high,medium,low} label.

Copy link
Collaborator

@saubyk saubyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@yyforyongyu yyforyongyu merged commit 89b54ab into lightningnetwork:master Feb 3, 2026
43 checks passed
@ellemouton ellemouton deleted the updateBWCompatBaseVersion branch February 4, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants