Pin sqldb package to pseudo-version#10556
Pin sqldb package to pseudo-version#10556Roasbeef merged 1 commit intolightningnetwork:v0.20.x-branchfrom
Conversation
This removes the local replace directive for the sqldb package and pins it to v1.0.12-0.20260113193010-8565d12e40b1 (commit 8565d12).
Summary of ChangesHello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the dependency management for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the sqldb dependency, removing the local replace directive and pinning it to a specific commit via a pseudo-version. This is a good step towards making the build process more standard. My review includes a comment about dependency management best practices, suggesting the use of a proper git tag for the sqldb module for better long-term maintainability, in line with the original TODO comment.
I am having trouble creating individual review comments. Click here to see my feedback.
go.mod (206-207)
The TODO comment states that the replace directive should be removed once the sqldb package is tagged. This change removes the directive but pins the dependency to a pseudo-version (a specific commit) rather than a git tag. While pinning to a commit is a valid approach, creating a tag for the sqldb module would provide clearer versioning and align better with the intent of the TODO. Using semantic version tags instead of pseudo-versions generally improves long-term maintainability and makes dependencies easier to track.
cac1646
into
lightningnetwork:v0.20.x-branch
This removes the local replace directive for the sqldb package and
pins it to v1.0.12-0.20260113193010-8565d12e40b1 (commit 8565d12).