Skip to content

Pin sqldb package to pseudo-version#10556

Merged
Roasbeef merged 1 commit intolightningnetwork:v0.20.x-branchfrom
ziggie1984:v0.20.x-branch
Feb 5, 2026
Merged

Pin sqldb package to pseudo-version#10556
Roasbeef merged 1 commit intolightningnetwork:v0.20.x-branchfrom
ziggie1984:v0.20.x-branch

Conversation

@ziggie1984
Copy link
Collaborator

This removes the local replace directive for the sqldb package and
pins it to v1.0.12-0.20260113193010-8565d12e40b1 (commit 8565d12).

This removes the local replace directive for the sqldb package and
pins it to v1.0.12-0.20260113193010-8565d12e40b1 (commit 8565d12).
@ziggie1984 ziggie1984 self-assigned this Feb 5, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @ziggie1984, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the dependency management for the sqldb package. It transitions from using a local replacement for development purposes to pinning the package to a specific pseudo-version. This change ensures that the project consistently uses a defined version of the sqldb module, improving build reproducibility and removing a temporary development-specific configuration.

Highlights

  • Dependency Update: The sqldb package dependency has been updated from v1.0.11 to a specific pseudo-version v1.0.12-0.20260113193010-8565d12e40b1.
  • Local Replace Directive Removal: The temporary local replace directive for the sqldb package, which pointed to a local path (./sqldb), has been removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • go.mod
    • Updated the github.com/lightningnetwork/lnd/sqldb module version to v1.0.12-0.20260113193010-8565d12e40b1.
    • Removed the replace directive for github.com/lightningnetwork/lnd/sqldb that pointed to a local path.
  • go.sum
    • Added new checksum entries for the updated github.com/lightningnetwork/lnd/sqldb pseudo-version.
Activity
  • No human activity (comments, reviews, or approvals) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sqldb dependency, removing the local replace directive and pinning it to a specific commit via a pseudo-version. This is a good step towards making the build process more standard. My review includes a comment about dependency management best practices, suggesting the use of a proper git tag for the sqldb module for better long-term maintainability, in line with the original TODO comment.

I am having trouble creating individual review comments. Click here to see my feedback.

go.mod (206-207)

medium

The TODO comment states that the replace directive should be removed once the sqldb package is tagged. This change removes the directive but pins the dependency to a pseudo-version (a specific commit) rather than a git tag. While pinning to a commit is a valid approach, creating a tag for the sqldb module would provide clearer versioning and align better with the intent of the TODO. Using semantic version tags instead of pseudo-versions generally improves long-term maintainability and makes dependencies easier to track.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📀

@Roasbeef Roasbeef merged commit cac1646 into lightningnetwork:v0.20.x-branch Feb 5, 2026
41 of 43 checks passed
@github-project-automation github-project-automation bot moved this to Done in lnd v0.20 Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants