amp: add counter for child index#5255
Draft
halseth wants to merge 1 commit intolightningnetwork:masterfrom
Draft
amp: add counter for child index#5255halseth wants to merge 1 commit intolightningnetwork:masterfrom
halseth wants to merge 1 commit intolightningnetwork:masterfrom
Conversation
halseth
commented
Apr 28, 2021
| // Since splitting the current share added new 32-byte | ||
| // randomness to the shares, we reset the childIndex. | ||
| child = left.Child(0) | ||
| s.childIndex = 0 |
Contributor
Author
There was a problem hiding this comment.
maybe it shouldn't be reset, since if you split and merge, then start doing last shards, you get collisions again.
Contributor
|
What's this @halseth? 🤔 😄 |
Contributor
Author
I'm fulfilling wishes: #5159 (comment) |
Contributor
|
Haha, nice, appreciated. Missed that earlier comment. If it wraps around, you can always fail the payment. Unlike the random index, which leads to silent collisions 👻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.