[MICRO]: channeldb+lnwallet: add OpeningParty API#8968
Merged
Roasbeef merged 1 commit intolightningnetwork:masterfrom Aug 5, 2024
Merged
[MICRO]: channeldb+lnwallet: add OpeningParty API#8968Roasbeef merged 1 commit intolightningnetwork:masterfrom
Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
ProofOfKeags
force-pushed
the
opening-party
branch
from
0c25495 to
ca9f29c
Compare
ProofOfKeags
added
size/nano
ProofOfKeags
changed the title
Roasbeef
requested changes
Aug 2, 2024
channeldb/channel.go
Outdated
| if c.IsInitiator { | ||
| return lntypes.Local | ||
| } else { | ||
| return lntypes.Remote |
Member
There was a problem hiding this comment.
Can do an early return as the linter notes.
Collaborator
Author
There was a problem hiding this comment.
It's not really an early return though. Both levels are "equally privileged". I'll change though to please the lint gods.
ProofOfKeags
force-pushed
the
opening-party
branch
from
ca9f29c to
5341529
Compare
carlaKC
approved these changes
Aug 2, 2024
…nnel This commit introduces a new API to return information on which party opened the channel using the new ChannelParty type. It does not change the underlying structure of how we store this information.
ProofOfKeags
force-pushed
the
opening-party
branch
from
5341529 to
a2b19af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Spinoff from #8755. Useful for #8270 refactor. Simple API addition to convert database boolean representation to the ChannelParty domain type.
Steps to Test
n/a
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.