Skip to content

LCORE-694: new configuration option #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisnik merged 3 commits into from
Jan 13, 2026
Merged

LCORE-694: new configuration option #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba5f634
New configuration option
tisnik Jan 13, 2026
6cb764f
Updated unit tests
tisnik Jan 13, 2026
718be3d
Updated documentation accordingly
tisnik Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions docs/config.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,11 @@ <h2 id="action">Action</h2>
<h2 id="authenticationconfiguration">AuthenticationConfiguration</h2>
<p>Authentication configuration.</p>
<table>
<colgroup>
<col style="width: 26%"/>
<col style="width: 23%"/>
<col style="width: 50%"/>
</colgroup>
<thead>
<tr class="header">
<th>Field</th>
Expand All @@ -280,26 +285,31 @@ <h2 id="authenticationconfiguration">AuthenticationConfiguration</h2>
<td/>
</tr>
<tr class="odd">
<td>skip_for_health_probes</td>
<td>boolean</td>
<td>Skip authorization for readiness and liveness probes</td>
</tr>
<tr class="even">
<td>k8s_cluster_api</td>
<td>string</td>
<td/>
</tr>
<tr class="even">
<tr class="odd">
<td>k8s_ca_cert_path</td>
<td>string</td>
<td/>
</tr>
<tr class="odd">
<tr class="even">
<td>jwk_config</td>
<td/>
<td/>
</tr>
<tr class="even">
<tr class="odd">
<td>api_key_config</td>
<td/>
<td/>
</tr>
<tr class="odd">
<tr class="even">
<td>rh_identity_config</td>
<td/>
<td/>
Expand Down
1 change: 1 addition & 0 deletions docs/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Authentication configuration.
|-------|------|-------------|
| module | string | |
| skip_tls_verification | boolean | |
| skip_for_health_probes | boolean | Skip authorization for readiness and liveness probes |
| k8s_cluster_api | string | |
| k8s_ca_cert_path | string | |
| jwk_config | | |
Expand Down
8 changes: 7 additions & 1 deletion docs/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4891,6 +4891,12 @@
"title": "Skip Tls Verification",
"default": false
},
"skip_for_health_probes": {
"type": "boolean",
"title": "Skip authentication for probes",
"description": "Skip authentication for readiness and liveness probes",
"default": false
},
"k8s_cluster_api": {
"anyOf": [
{
Expand Down Expand Up @@ -8858,4 +8864,4 @@
}
}
}
}
}
11 changes: 10 additions & 1 deletion src/models/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,13 @@ class AuthenticationConfiguration(ConfigurationBase):

module: str = constants.DEFAULT_AUTHENTICATION_MODULE
skip_tls_verification: bool = False

# LCORE-694: Config option to skip authorization for readiness and liveness probe
skip_for_health_probes: bool = Field(
False,
title="Skip authorization for probes",
description="Skip authorization for readiness and liveness probes",
)
k8s_cluster_api: Optional[AnyHttpUrl] = None
k8s_ca_cert_path: Optional[FilePath] = None
jwk_config: Optional[JwkConfiguration] = None
Expand Down Expand Up @@ -1518,7 +1525,9 @@ class Configuration(ConfigurationBase):
)

authentication: AuthenticationConfiguration = Field(
default_factory=AuthenticationConfiguration,
default_factory=lambda: AuthenticationConfiguration(
skip_for_health_probes=False
),
title="Authentication configuration",
description="Authentication configuration",
)
Expand Down
32 changes: 32 additions & 0 deletions tests/unit/models/config/test_authentication_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@ def test_authentication_configuration() -> None:
auth_config = AuthenticationConfiguration(
module=AUTH_MOD_NOOP,
skip_tls_verification=False,
skip_for_health_probes=False,
k8s_ca_cert_path=None,
k8s_cluster_api=None,
)
assert auth_config is not None
assert auth_config.module == AUTH_MOD_NOOP
assert auth_config.skip_tls_verification is False
assert auth_config.skip_for_health_probes is False
assert auth_config.k8s_ca_cert_path is None
assert auth_config.k8s_cluster_api is None
assert auth_config.rh_identity_config is None
Expand Down Expand Up @@ -295,6 +297,36 @@ def test_authentication_configuration_in_config_noop() -> None:
assert cfg.authentication.k8s_cluster_api is None


def test_authentication_configuration_skip_readiness_probe() -> None:
"""Test the authentication configuration in main config."""
# pylint: disable=no-member
cfg = Configuration(
name="test_name",
service=ServiceConfiguration(),
llama_stack=LlamaStackConfiguration(
use_as_library_client=True,
library_client_config_path="tests/configuration/run.yaml",
),
user_data_collection=UserDataCollection(
feedback_enabled=False, feedback_storage=None
),
mcp_servers=[],
authentication=AuthenticationConfiguration(
module=AUTH_MOD_K8S,
skip_tls_verification=True,
skip_for_health_probes=True,
k8s_ca_cert_path="tests/configuration/server.crt",
k8s_cluster_api=None,
),
)
assert cfg.authentication is not None
assert cfg.authentication.module == AUTH_MOD_K8S
assert cfg.authentication.skip_tls_verification is True
assert cfg.authentication.skip_for_health_probes is True
assert cfg.authentication.k8s_ca_cert_path == Path("tests/configuration/server.crt")
assert cfg.authentication.k8s_cluster_api is None


def test_authentication_configuration_in_config_k8s() -> None:
"""Test the authentication configuration in main config."""
# pylint: disable=no-member
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/models/config/test_dump_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ def test_dump_configuration(tmp_path: Path) -> None:
"authentication": {
"module": "noop",
"skip_tls_verification": False,
"skip_for_health_probes": False,
"k8s_ca_cert_path": None,
"k8s_cluster_api": None,
"jwk_config": None,
Expand Down Expand Up @@ -461,6 +462,7 @@ def test_dump_configuration_with_quota_limiters(tmp_path: Path) -> None:
"authentication": {
"module": "noop",
"skip_tls_verification": False,
"skip_for_health_probes": False,
"k8s_ca_cert_path": None,
"k8s_cluster_api": None,
"jwk_config": None,
Expand Down Expand Up @@ -676,6 +678,7 @@ def test_dump_configuration_with_quota_limiters_different_values(
"authentication": {
"module": "noop",
"skip_tls_verification": False,
"skip_for_health_probes": False,
"k8s_ca_cert_path": None,
"k8s_cluster_api": None,
"jwk_config": None,
Expand Down Expand Up @@ -871,6 +874,7 @@ def test_dump_configuration_byok(tmp_path: Path) -> None:
"authentication": {
"module": "noop",
"skip_tls_verification": False,
"skip_for_health_probes": False,
"k8s_ca_cert_path": None,
"k8s_cluster_api": None,
"jwk_config": None,
Expand Down Expand Up @@ -1055,6 +1059,7 @@ def test_dump_configuration_pg_namespace(tmp_path: Path) -> None:
"authentication": {
"module": "noop",
"skip_tls_verification": False,
"skip_for_health_probes": False,
"k8s_ca_cert_path": None,
"k8s_cluster_api": None,
"jwk_config": None,
Expand Down
Loading