[LCORE-702] Add e2e tests for error status codes for the /query endpoint

[max-svistunov]

Description

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

• Assisted-by: Claude Opus 4.5
• Generated by: Claude Opus 4.5

Related Tickets & Documents

• Related Issue https://issues.redhat.com/browse/LCORE-702
• Closes https://issues.redhat.com/browse/LCORE-702

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

• Tests
  • Expanded end-to-end error handling coverage with two new scenarios: missing authorization token (401) and non-existent model (404), augmenting existing invalid-authentication tests.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds two end-to-end test scenarios to tests/e2e/features/query.feature covering missing Authorization bearer token (expects 401) and non-existent model requests (expects 404).

Changes

Cohort / File(s)	Summary
E2E Query Feature Tests tests/e2e/features/query.feature	Adds two error-handling scenarios: missing bearer token in Authorization header (expects 401 and "No token found in Authorization header") and request for a non-existent model (expects 404 and "Model not found").

Sequence Diagram(s)

(omitted — changes are test additions only and do not introduce new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• LCORE-488: Add E2E tests for query endpoint #616: Modifies the same e2e query endpoint tests by adding/adjusting authorization and error-handling scenarios.

Suggested reviewers

• tisnik

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly and clearly summarizes the main change: adding end-to-end tests for error status codes on the /query endpoint, which matches the changeset that adds two new error-handling test scenarios.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 791bd37 and 5de06b3.

📒 Files selected for processing (1)

• tests/e2e/features/query.feature

🧰 Additional context used

📓 Path-based instructions (1)

tests/e2e/features/**/*.feature

📄 CodeRabbit inference engine (CLAUDE.md)

Use behave (BDD) framework with Gherkin feature files for end-to-end tests

Files:

• tests/e2e/features/query.feature

🧠 Learnings (1)

📓 Common learnings

Learnt from: radofuchs
Repo: lightspeed-core/lightspeed-stack PR: 485
File: tests/e2e/features/environment.py:87-95
Timestamp: 2025-09-02T11:09:40.404Z
Learning: In the lightspeed-stack e2e tests, noop authentication tests use the default lightspeed-stack.yaml configuration, while noop-with-token tests use the Authorized tag to trigger a config swap to the specialized noop-with-token configuration file.

Learnt from: radofuchs
Repo: lightspeed-core/lightspeed-stack PR: 485
File: tests/e2e/test_list.txt:2-3
Timestamp: 2025-09-02T11:15:02.411Z
Learning: In the lightspeed-stack e2e tests, the Authorized tag is intentionally omitted from noop authentication tests because they are designed to test against the default lightspeed-stack.yaml configuration rather than the specialized noop-with-token configuration.

Learnt from: CR
Repo: lightspeed-core/lightspeed-stack PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-01-11T16:30:41.784Z
Learning: Applies to tests/e2e/features/**/*.feature : Use behave (BDD) framework with Gherkin feature files for end-to-end tests

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build-pr
• GitHub Check: E2E: library mode / ci
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request

🔇 Additional comments (2)

tests/e2e/features/query.feature (2)

67-75: LGTM!

This scenario correctly tests the edge case where the Authorization header is present but contains no actual token after "Bearer". This complements the existing scenario (lines 50-65) that tests the completely missing header case. The step definitions are consistent with the rest of the file.

---

77-85: LGTM!

The scenario appropriately tests the 404 error path for non-existent model/provider combinations. Using hardcoded strings "does-not-exist" instead of placeholders is correct here since the intent is to ensure the model lookup fails. The test correctly requires valid authentication (via the @Authorized tag and bearer token) before testing the model validation logic.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[radofuchs]

LGTM

[tisnik]

LGTM