hsilva/validation template #6
Conversation
| @@ -0,0 +1,3 @@ | |||
| module github.com/lightstep/integrations | |||
|
|
|||
| go 1.19 | |||
There was a problem hiding this comment.
| go 1.19 | |
| go 1.20 |
| package text | ||
|
|
||
| import ( | ||
| "io/ioutil" |
There was a problem hiding this comment.
nit: contents of "ioutil" have migrated to either "os" or "io". In general, preferred to use the versions in those packages as "ioutil" is deprecated.
| @@ -0,0 +1,147 @@ | |||
| package text | |||
There was a problem hiding this comment.
For unit tests, using package text_test provides some useful guarantees. It requires writing tests in the same way you'll use the code.
nslaughter
left a comment
nslaughter
left a comment
There was a problem hiding this comment.
I've made 3 comments: (1) is the go.mod version, (2) is to switch to test the package using the package {{pkg name}}_test form, (3) is switch from ioutil to new versions of the functions - including new names for temp fs related things (see comments).
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Create a temp file | ||
| tempFile, err := ioutil.TempFile("", "template") |
There was a problem hiding this comment.
Usually when I'm looking for the old ioutil functions I expect to find the function lifted and shifted to io or os. But for the temp fs functions they made new function names - os.CreateTemp for new files and os.MkdirTemp for directories.
Uh oh!
There was an error while loading. Please reload this page.