refactor: rsync and scp into copytool pkg#4521
Open
unsuman wants to merge 1 commit intolima-vm:masterfrom
Open
refactor: rsync and scp into copytool pkg#4521unsuman wants to merge 1 commit intolima-vm:masterfrom
rsync and scp into copytool pkg#4521unsuman wants to merge 1 commit intolima-vm:masterfrom
Conversation
dfae0dd to
ab7df73
Compare
Contributor
Author
|
Left with the refactoring of rsync in the |
446bcf2 to
7a1a01e
Compare
Member
|
Needs rebase |
Contributor
Author
|
I'll rebase it once #4563 is merged |
3aa385a to
ae6380f
Compare
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
ae6380f to
0cd036a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the file copying logic (rsync and scp) out of
cmd/limactland into a new packagecopytool.Changes were made by creating a
pkg/copytoolwith a commonCopyToolinterface, moving the rsync and scp command generation logic into this new package, and updatinglimactl copyandlimactl shellto utilise the new package, which resulted in the removal of duplicated logic inshell.go.Fixes
Originally posted by @unsuman in #4429 (comment)