Skip to content

limactl should never ignore errors from store.Inspect#4579

Merged
AkihiroSuda merged 1 commit intolima-vm:masterfrom
jandubois:limactl-shell
Feb 15, 2026
Merged

limactl should never ignore errors from store.Inspect#4579
AkihiroSuda merged 1 commit intolima-vm:masterfrom
jandubois:limactl-shell

Conversation

@jandubois
Copy link
Member

@jandubois jandubois commented Feb 13, 2026

No description provided.

@jandubois jandubois added this to the v2.1.0 milestone Feb 13, 2026
return err
}
if len(inst.Errors) > 0 {
logrus.Errorf("Instance %q has configuration errors: %s", instName, errors.Join(inst.Errors...))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use logrus.WithError

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed:

l shell alpine-iso uname -a
ERRO[0000] Instance "alpine-iso" has configuration errors  error="failed to connect to \"/Users/jan/.lima/alpine-iso/ha.sock\": stat /Users/jan/.lima/alpine-iso/ha.sock: no such file or directory\nmessage \"{{.foo}\" is not a valid template: template: format:1: bad character U+007D '}'"
Bad port '0'

Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 7286f71 into lima-vm:master Feb 15, 2026
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants