pkg/downloader: CacheKey: pass ext to decompressor()#4585
Closed
AkihiroSuda wants to merge 2 commits intolima-vm:masterfrom
Closed
pkg/downloader: CacheKey: pass ext to decompressor()#4585AkihiroSuda wants to merge 2 commits intolima-vm:masterfrom
AkihiroSuda wants to merge 2 commits intolima-vm:masterfrom
Conversation
`decompressor()` excepts a file extension, not an entire URL Follow-up to PR 4067 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
fix-cachekey-decomp
branch
from
325737a to
0729c8c
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
Let's rather just revert the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decompressor()excepts a file extension, not an entire URLFollow-up to: