Conversions between Euclid and Kurbo types#463
Merged
sagudev merged 1 commit intolinebender:mainfrom Jul 11, 2025
Merged
Conversation
|
This would potentially be useful for Blitz. If we're going to do this, then I think having the conversions in |
Contributor
Author
That was also my rationale. |
sagudev
commented
Jul 7, 2025
jneem
reviewed
Jul 7, 2025
sagudev
force-pushed
the
euclid
branch
3 times, most recently
from
97f6815 to
a49a650
Compare
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
jneem
approved these changes
Jul 8, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
We already did for most of `Point` arguments. This is especially relevant for users of euclid now that we have #463. Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
DJMcNab
added a commit
to DJMcNab/kurbo
that referenced
this pull request
Aug 11, 2025
The `euclid` feature is only intended for conversions (see linebender#463) Therefore, if our users are using it, they should be enabling the correct features themselves Related to linebender#463 This has the side-effect of working around rust-lang/cargo#10801 (but that is not the motivation for this change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired after #450
We could use those in servo and blitz.
Theoretically they could also live in euclid, but given higher number of breaking releases in kurbo, kurbo seems better place for this.