Fix wrapping arithmetic in min_dist_param by limiting Bezier degree#542
Merged
tomcur merged 1 commit intolinebender:mainfrom Jan 22, 2026
Merged
Fix wrapping arithmetic in min_dist_param by limiting Bezier degree#542tomcur merged 1 commit intolinebender:mainfrom
min_dist_param by limiting Bezier degree#542tomcur merged 1 commit intolinebender:mainfrom
Conversation
In preparation for enabling the `clippy::cast_possible_wrap` lint. Currently the higest degree we use this function with are cubics, i.e. degree 3. By limiting the function for Beziers up to degree 255 we can easily prevent wrapping. This is somewhat theoretical, as the function is not tested at those degrees anyway (which I've left as comment on the function).
tomcur
force-pushed
the
push-xlrltmprkork
branch
from
5d972bb to
57788f8
Compare
jneem
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for enabling the
clippy::cast_possible_wraplint.Currently the higest degree we use this function with are cubics, i.e. degree 3. By limiting the function for Beziers up to degree 255 we can easily prevent wrapping.
This is somewhat theoretical, as the function is not tested at those degrees anyway (which I've left as comment on the function).