Port text rendering from ttf-parser to skrifa #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Diff images: 
|
oetiker
force-pushed
the
skrifa-minimal
branch
from
f02b713 to
24e8d86
Compare
This replaces ttf-parser with skrifa for all font parsing and text rendering. fontdb changes: - Vendor fontdb 0.23.0 as a workspace crate - Replace ttf-parser with skrifa for font parsing - Use skrifa's MetadataProvider for font attributes and metrics usvg changes: - Add skrifa_colr.rs: COLR glyph painting using skrifa's ColorPainter - Add skrifa_metrics.rs: Font metrics extraction using skrifa - Update flatten.rs: Use skrifa for glyph outlines and bitmap extraction - Update layout.rs: Use skrifa for font metrics and harfrust for shaping - Replace rustybuzz with harfrust for text shaping - Update test reference images for new skrifa-based rendering Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
oetiker
force-pushed
the
skrifa-minimal
branch
from
24e8d86 to
fe95143
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces ttf-parser with skrifa for all font parsing and text rendering.
This is an alternative approach to #922 - see comparison below.
fontdb changes:
usvg changes:
Comparison with #922
main(includes variable fonts #997, Rust 2024)skrifa_colr.rsusing ColorPaintercolr.rsKey differences:
Test plan
cargo test --workspace)🤖 Generated with Claude Code