Skip to content

Conversation

@srnand
Copy link
Collaborator

@srnand srnand commented Jan 6, 2026

Summary

  • Added implementation for SQL commands to pause, resume and drop TableTriggers.
  • When paused, triggers will not create new jobs, but existing jobs will complete gracefully.
  • Added paused boolean field to TableTrigger CRD spec.
  • Updated TableTriggerReconciler to check spec.paused flag early in reconciliation
    • When paused=true:
      • Prevents creation of new jobs (scheduled or watermark-based)
      • Continues monitoring existing jobs to allow graceful completion
      • Updates watermarks for completed jobs
    • When paused=false: Normal trigger operation resumes

Test

  • Added UTs for reconciliation.
  • Added Integration testing queries for new pause/resume/drop trigger sql.
    • (DONE) Need to add DROP TRIGGER support for the integration test to pass.

Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow! Nice work!

@srnand srnand changed the title Add PAUSE/RESUME TRIGGER support for TableTriggers Add PAUSE/RESUME/DROP TRIGGER support for TableTriggers Jan 7, 2026
@srnand srnand force-pushed the sthakar/jan6/supportPauseResumeGrammar branch from e160267 to ecc1b4c Compare January 7, 2026 13:51
@srnand srnand force-pushed the sthakar/jan6/supportPauseResumeGrammar branch from ecc1b4c to 77ed568 Compare January 7, 2026 16:54
@srnand srnand merged commit 84c65e3 into main Jan 7, 2026
1 check passed
@srnand srnand deleted the sthakar/jan6/supportPauseResumeGrammar branch January 7, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants