Fix fastserde to support classes generated by our own avro-builder #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-ukumar
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avro-builder was recently updated to generate java bindings by extending
SpecificRecordBaseExtclass.when using fastserde, proper classpath is not set and therefore
SpecificRecordBaseExtclass is not included into the classpath when compiling classes generated by fastserde.This PR is making a quick fix by adding
SpecificRecordBaseExtandCustomDecoderas well known classes, so class-path generator can resolve their jar files and add them to classpass.Also added a test to reproduce the issue and confirm that it is fixed.