Skip to content

Adding support for secondary input decryption #89

Merged
avinas-kumar merged 5 commits intolinkedin:masterfrom
gautamshanu:master
Jun 3, 2025
Merged

Adding support for secondary input decryption #89
avinas-kumar merged 5 commits intolinkedin:masterfrom
gautamshanu:master

Conversation

@gautamshanu
Copy link
Contributor

Dear DIL maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • My PR addresses the following JIRA issues and references them in the PR title.

Description

  • Here are some details about my PR, including screenshots (if applicable):

There's a new requirement of having support for decryption of secondary input values. One of the flows needs to be able to provide an encrypted token as a secondary input which can be used under ms.parameters.
Without this change, the value under ms.parameter was not eligible to be decrypted even if it's of the form ENC(..)

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

The flow that has this requirement, has been tested. Earlier it used to make the HTTP call with ENC(...) under the parameters. Now, it first decrypts and then makes the HTTP call.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@avinas-kumar avinas-kumar merged commit 850b8dd into linkedin:master Jun 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants