[LIZK-4062] [Build-related-change] Consolidate all the build/test related change/configuration into a single commit for future upgrade integration #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry picked e2e tests from upstream. This checks basic backward compatibility and regression testing. For original PR : apache/zookeeper@609afd1 Co-authored-by: tison <wander4096@gmail.com>
This has merged all the changes from li-dev branch. There is still a problem where it is not able to find snapshot as it needs to look at the local m2 repository.
…ated change/configuration into a single commit for future upgrade integration
laxman-ch
reviewed
Nov 24, 2025
|
|
||
| ephemeralNodesTotalByteLimit = Integer.getInteger(EPHEMERAL_NODES_TOTAL_BYTE_LIMIT_KEY, DEFAULT_EPHEMERAL_NODES_TOTAL_BYTE_LIMIT); | ||
| LOG.info("{} = {}",EPHEMERAL_NODES_TOTAL_BYTE_LIMIT_KEY, ephemeralNodesTotalByteLimit); | ||
| LOG.info("{} = {}", EPHEMERAL_NODES_TOTAL_BYTE_LIMIT_KEY, ephemeralNodesTotalByteLimit); |
There was a problem hiding this comment.
These formatting changes and imports changes - are they mandatory to fix them to make some builds (static analysis tools) pass?
Do you want to keep these changes separate if we must need them?
Collaborator
Author
There was a problem hiding this comment.
These are the imported changes, I don't think we need them separate as they all link with build issues,
So I think it's fine to have them in the same pr ?
laxman-ch
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Write a concise description including what, why, how)
[LIZK-4062] [Build-related-change] Consolidate all the build/test related change/configuration into a single commit for future upgrade integration
Tests
The following tests are written for this issue:
(List the names of added unit/integration tests)
Following test validation has been performed for this pr :-
Ran nvm install locally and it worked
[INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache ZooKeeper 3.8.4: [INFO] [INFO] Apache ZooKeeper ................................... SUCCESS [ 1.389 s] [INFO] Apache ZooKeeper - Documentation ................... SUCCESS [ 0.403 s] [INFO] Apache ZooKeeper - Jute ............................ SUCCESS [ 4.149 s] [INFO] Apache ZooKeeper - Server .......................... SUCCESS [ 8.879 s] [INFO] Apache ZooKeeper - Metrics Providers ............... SUCCESS [ 0.119 s] [INFO] Apache ZooKeeper - Prometheus.io Metrics Provider .. SUCCESS [ 1.116 s] [INFO] Apache ZooKeeper - Client .......................... SUCCESS [ 0.102 s] [INFO] Apache ZooKeeper - Recipes ......................... SUCCESS [ 0.243 s] [INFO] Apache ZooKeeper - Recipes - Election .............. SUCCESS [ 0.314 s] [INFO] Apache ZooKeeper - Recipes - Lock .................. SUCCESS [ 0.326 s] [INFO] Apache ZooKeeper - Recipes - Queue ................. SUCCESS [ 0.305 s] [INFO] Apache ZooKeeper - Assembly ........................ SUCCESS [ 1.376 s] [INFO] Apache ZooKeeper - Compatibility Tests ............. SUCCESS [ 0.092 s] [INFO] Apache ZooKeeper - Compatibility Tests - Curator ... SUCCESS [ 0.289 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 19.177 s [INFO] Finished at: 2025-11-23T18:04:18+05:30 [INFO] ------------------------------------------------------------------------Zk server is running locally
The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)