Open
Conversation
cdunn
commented
Nov 16, 2018
cdunn
commented
- One test still failing, might be a slate issue
Owner
|
Is that related to ianstormtaylor/slate#2336 ? |
Fix slate keys while doing development against a local slate. Add exit block creation for arrow key up/down on first/last code line in block.
|
In case it's helpful to anyone, I've added somewhat similar behavior from this plugin to the slate-plugins code-block. My implementation does not support config of tabs vs. spaces for indentation, but otherwise supports most of what was here, but works against the latest versions of Slate. I originally would have preferred to use what was here, but needed something working against modern slate. Thanks for the inspiration. |
Owner
|
Great work！Glad to see it, I will check it out if I use slate again. I personally use Tiddlywiki.js to build my knowledge base now, not using slate anymore... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.