Fix HANDLE_LEAK.EX in aulast.c#511
Merged
stevegrubb merged 1 commit intolinux-audit:masterfrom Feb 28, 2026
Merged
Conversation
Close file handle 'f' before returning error in argument parsing to prevent resource leak when --extract option is followed by an invalid argument. Svace report: Handle 'f' is created at aulast.c:506 by calling function 'fopen' and lost at aulast.c:506. (CWE404, CWE775) This leaks happens in the end of main() and could be not fixed, but let's make static analyzers happy... Example scaniors of leaks: aulast --extract -f file -f file2 aulast -f file --extract --stdin aulast --extract --user u1 --user u2 aulast --extract --tty t1 --tty t2 aulast --extract --invalid Co-authored-by: Z.AI GLM-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close file handle 'f' before returning error in argument parsing to prevent resource leak when --extract option is followed by an invalid argument.
Svace report:
Handle 'f' is created at aulast.c:506 by calling function 'fopen'
and lost at aulast.c:506. (CWE404, CWE775)
This leaks happens in the end of main() and could be not fixed, but let's make static analyzers happy...
Example scaniors of leaks:
aulast --extract -f file -f file2
aulast -f file --extract --stdin
aulast --extract --user u1 --user u2
aulast --extract --tty t1 --tty t2
aulast --extract --invalid