Fix INTEGER_OVERFLOW in gen_tables.h#512
Merged
stevegrubb merged 1 commit intolinux-audit:masterfrom Feb 28, 2026
Merged
Conversation
Use ssize_t instead of size_t for binary search index Fix integer underflow in gen_tables.h by changing mid from size_t to ssize_t in s2i__() and i2s_bsearch__(). This prevents mid - 1 from wrapping to SIZE_MAX when mid is 0, which would break the binary search loop termination condition. Resolves Svace INTEGER_OVERFLOW warning (for audit-userspace v3.0.8): An integer underflow may occur due to arithmetic operation (unsigned subtraction) between variable 'mid' and value '1', when 'mid' is equal to '0' (CWE125, CWE190, CWE191) Location: gen_tables.h:90 Co-authored-by: Z.AI GLM-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ssize_t instead of size_t for binary search index
Fix integer underflow in gen_tables.h by changing mid from size_t to ssize_t in s2i__() and i2s_bsearch__(). This prevents mid - 1 from wrapping to SIZE_MAX when mid is 0, which would break the binary search loop termination condition.
Resolves Svace INTEGER_OVERFLOW warning (for audit-userspace v3.0.8):
An integer underflow may occur due to arithmetic operation
(unsigned subtraction) between variable 'mid' and value '1',
when 'mid' is equal to '0' (CWE125, CWE190, CWE191)
Location: gen_tables.h:90