Fix MEMORY_LEAK.EX in delete_all.c#513
Merged
stevegrubb merged 1 commit intolinux-audit:masterfrom Feb 28, 2026
Merged
Conversation
Add list_clear(&l) before returning -1 on error paths to prevent memory leak of rule list allocated by list_append(). Svace report: Dynamic memory, referenced by 'newnode->r', is allocated at delete_all.c:87 by calling function 'list_append' and lost at delete_all.c:79. (CWE401, CWE404, CWE775) Co-authored-by: Z.AI GLM-5
Contributor
|
This is only used by auditctl -D. Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add list_clear(&l) before returning -1 on error paths to prevent memory leak of rule list allocated by list_append().
Svace report:
Dynamic memory, referenced by 'newnode->r', is allocated at
delete_all.c:87 by calling function 'list_append' and lost at
delete_all.c:79. (CWE401, CWE404, CWE775)