Fix NO_CAST.INTEGER_OVERFLOW in libev ev.c array_nextsize#515
Open
mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
Open
Fix NO_CAST.INTEGER_OVERFLOW in libev ev.c array_nextsize#515mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
Conversation
Add explicit casts to size_t in arithmetic expressions to prevent potential integer overflow when calculating array sizes. Overflows are not very realistic, but improve code robustness and make analyzers happy. Svace reports: 1) The value of 'elem * ncur' may overflow (ev.c:2259) 2) The value of 'ncur + elem + (MALLOC_ROUND - 1)' may overflow (ev.c:2262) 3) The value of 'elem * *cur' may overflow (ev.c:2275) (CWE190, CWE197) Co-authored-by: Z.AI GLM-5
Contributor
|
Thanks for looking at this. But I really don't like changing libev much. The reason why is it has it's own upstream. Every libev release requires remembering everything that needs patching. Maybe libev upstream would like the patch? They don't use git. You'd have to submit it to their mail list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit casts to size_t in arithmetic expressions to prevent potential integer overflow when calculating array sizes.
Overflows are not very realistic, but improve code robustness and make analyzers happy.
Svace reports:
(CWE190, CWE197)