ci: ansible-lint - remove .collection directory from converted collection [citest_skip]

[richm]

The new ansible-lint@v26 does not like it when there is a .collection directory
with a galaxy.yml in the converted collection, so remove it, since it is not
needed for ansible-lint.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

• Extend the ansible-lint workflow cleanup step to also remove the converted collection's .collection directory before running ansible-lint.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the ansible-lint CI workflow to additionally remove the temporary .collection directory from the converted collection before running ansible-lint, ensuring compatibility with ansible-lint v26.

Sequence diagram for updated ansible-lint CI cleanup workflow

sequenceDiagram
    participant GitHubActions
    participant Runner
    participant tox
    participant ConvertedCollection
    participant ansible_lint_action

    GitHubActions->>Runner: Start ansible-lint job
    Runner->>tox: Run TOXENV=collection lsr_ci_runtox
    tox->>ConvertedCollection: Generate converted collection in .tox/ansible_collections
    tox-->>Runner: Return coll_dir path

    Note over Runner,ConvertedCollection: Updated cleanup step
    Runner->>ConvertedCollection: rm -rf coll_dir/.ansible
    Runner->>Runner: rm -rf .tox/ansible-plugin-scan
    Runner->>ConvertedCollection: rm -rf coll_dir/.collection

    Runner->>ConvertedCollection: mkdir -p coll_dir/.git
    Runner->>ansible_lint_action: Invoke ansible-lint v26 on converted collection
    ansible_lint_action-->>GitHubActions: Report lint results

Loading

File-Level Changes

Change	Details	Files
Extend the cleanup step in the ansible-lint GitHub Actions workflow to delete the .collection directory in the converted collection.	Update the cleanup rm -rf command in the ansible-lint workflow job to include the converted collection’s .collection directory Preserve existing cleanup of the .ansible directory and .tox/ansible-plugin-scan artifacts Keep the rest of the ansible-lint job configuration, including the .git bootstrapping, unchanged	.github/workflows/ansible-lint.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider adding a -- separator to the rm -rf command (e.g. rm -rf -- "$coll_dir/.ansible" .tox/ansible-plugin-scan "$coll_dir/.collection") to guard against any edge cases where a variable might expand to a value beginning with -.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider adding a `--` separator to the `rm -rf` command (e.g. `rm -rf -- "$coll_dir/.ansible" .tox/ansible-plugin-scan "$coll_dir/.collection"`) to guard against any edge cases where a variable might expand to a value beginning with `-`.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}