Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Feb 10, 2026

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

CI:

  • Bump tox-lsr dependency from 3.14.0 to 3.15.0 in all GitHub Actions workflows, including ansible-lint, ansible-managed-var-comment, ansible-test, and qemu-kvm integration tests.

This adds back support for IPv6 in qemu VMs, which appears to be working now.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Feb 10, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.15.0 instead of 3.14.0 so CI (including qemu-based integration tests) benefits from the latest tooling, including restored IPv6 support in qemu VMs.

Flow diagram for qemu_kvm_integration_tests workflow with tox_lsr_3_15_0

flowchart TD
    trigger[on push or pull_request]
    job_start[Start qemu_kvm_integration_tests job]
    checkout[Checkout repository]
    setup_python[Set up Python]
    install_toxlsr[Install tox and tox_lsr 3_15_0]
    run_tox[Run tox-based integration tests]
    start_qemu[Start qemu VMs with IPv4 and IPv6]
    run_tests[Execute ansible tests against qemu VMs]
    collect_results[Collect and report test results]
    job_end[Job completes]

    trigger --> job_start --> checkout --> setup_python --> install_toxlsr --> run_tox
    run_tox --> start_qemu --> run_tests --> collect_results --> job_end
Loading

File-Level Changes

Change Details Files
Bump tox-lsr dependency version in all CI workflows.
  • Update ansible-lint workflow to install tox-lsr 3.15.0 via pip3 from the linux-system-roles GitHub repository.
  • Update ansible-managed-var-comment workflow to install tox-lsr 3.15.0.
  • Update ansible-test workflow to install tox-lsr 3.15.0 for collection-format conversion and tests.
  • Update qemu-kvm-integration-tests workflow to install tox-lsr 3.15.0 alongside qemu and related tooling.
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 5b4b9e9 into main Feb 10, 2026
11 checks passed
@richm richm deleted the tox-lsr-3.15.0 branch February 10, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant