refactor: simplify CMake version requirements#107
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom May 28, 2025
Merged
refactor: simplify CMake version requirements#107deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
1. Removed upper bound restriction on CMake version (3.10...3.27 → 3.10) 2. Removed explicit CMP0177 policy setting which is now default in newer CMake 3. Maintains minimum version requirement while allowing newer CMake versions 4. Makes build configuration more flexible for different environments refactor: 简化 CMake 版本要求 1. 移除了 CMake 版本的上限限制 (从 3.10...3.27 改为 3.10) 2. 移除了显式的 CMP0177 策略设置,该策略在新版 CMake 中已是默认 3. 保持最低版本要求的同时允许使用更新的 CMake 版本 4. 使构建配置对不同环境更具灵活性
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin pr auto review关键摘要:
是否建议立即修改:
|
Contributor
Author
|
/forcemerge |
Reviewer's GuideThis refactor streamlines the CMake configuration by dropping the upper-bound version restriction and removing an explicit policy override, preserving the minimum requirement while embracing newer CMake defaults for greater build flexibility. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
This pr force merged! (status: blocked) |
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake
versions
refactor: 简化 CMake 版本要求
Summary by Sourcery
Relax and simplify CMake version requirements to improve build flexibility
Enhancements:
Build: