feat: add Debian trigger integration for config updates#111
Merged
zccrs merged 1 commit intolinuxdeepin:masterfrom Jun 20, 2025
Merged
feat: add Debian trigger integration for config updates#111zccrs merged 1 commit intolinuxdeepin:masterfrom
zccrs merged 1 commit intolinuxdeepin:masterfrom
Conversation
|
Warning
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Reviewer's GuideImplements a Debian trigger mechanism that installs a D-Bus-based handler script and configures packaging hooks to automatically process configuration file updates. Sequence diagram for Debian trigger-based config update processsequenceDiagram
participant DebianPkg as Debian Package System
participant Trigger as Trigger System
participant Handler as dconfig-trigger-handler
participant DConfig as dde-dconfig-daemon (D-Bus)
DebianPkg->>Trigger: Install/Update config file in monitored directory
Trigger->>Handler: Activate dconfig-trigger-handler script
Handler->>DConfig: Notify config change via D-Bus
DConfig-->>Handler: Process config update
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
zccrs
requested changes
Jun 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Debian triggers to automate configuration updates during package installation by adding a D-Bus handler script, Debian packaging files, and related build/install configuration updates.
- Added a new dconfig-trigger-handler script to process configuration file changes via D-Bus
- Integrated Debian trigger system through new .triggers and postinst scripts for monitoring configuration directories and managing timestamps
- Updated CMakeLists and install manifests, and adjusted packaging metadata for proper deployment
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| debian/dde-dconfig-daemon.triggers | Added trigger definitions to monitor configuration directories |
| debian/dde-dconfig-daemon.postinst | Introduced post-install script to reload systemd and update timestamps |
| debian/dde-dconfig-daemon.install | Updated file list to deploy the new trigger handler script |
| dconfig-center/dde-dconfig-daemon/scripts/dconfig-trigger-handler | New script to handle configuration updates via D-Bus |
| dconfig-center/dde-dconfig-daemon/CMakeLists.txt | Updated installation steps to include the trigger handler script |
| .reuse/dep5 | Added licensing information for new scripts |
Comments suppressed due to low confidence (1)
dconfig-center/dde-dconfig-daemon/scripts/dconfig-trigger-handler:107
- The logic creates the timestamp file before scanning for new files in process_newer_files_in_directory, which may lead to skipping configuration changes that occurred before the file was created. Consider performing the directory scan first and then updating the timestamp file after processing to ensure all relevant changes are captured.
if [ ! -f "$TIMESTAMP_FILE" ]; then
|
Warning
|
|
Warning
|
1. Added dconfig-trigger-handler script to process configuration file changes via D-Bus 2. Implemented Debian trigger system to monitor config directories (/ usr/share/dsg/configs, /etc/dsg/configs, /var/lib/linglong entries) 3. Created postinst script to handle trigger activation and timestamp management 4. Added documentation explaining the trigger integration process and usage 5. Updated CMakeLists and install files to deploy the trigger handler 6. The changes enable automatic configuration updates when package installations modify config files feat: 添加 Debian 触发器集成以支持配置自动更新 1. 新增 dconfig-trigger-handler 脚本通过 D-Bus 处理配置文件变更 2. 实现 Debian 触发器系统监控配置目录(/usr/share/dsg/configs, /etc/dsg/ configs, /var/lib/linglong 条目) 3. 创建 postinst 脚本处理触发器激活和时间戳管理 4. 添加文档说明触发器集成流程和使用方法 5. 更新 CMakeLists 和安装文件以部署触发器处理程序 6. 这些变更使得在包安装修改配置文件时能够自动更新配置
|
Warning
|
zccrs
approved these changes
Jun 20, 2025
zccrs
approved these changes
Jun 20, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: 添加 Debian 触发器集成以支持配置自动更新
Summary by Sourcery
Integrate Debian triggers to automate configuration updates on package installation by adding a D-Bus handler script and updating build and Debian packaging files.
New Features:
Build:
Deployment: